Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add md_remediation test #1044

Merged
merged 1 commit into from
May 2, 2024
Merged

🌱 Add md_remediation test #1044

merged 1 commit into from
May 2, 2024

Conversation

mboukhalfa
Copy link
Member

@mboukhalfa mboukhalfa commented Jun 14, 2023 •
edited
Loading

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2023
@mboukhalfa
Copy link
Member Author

/test-centos-e2e-feature-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from 3c3117f to 109d81b Compare June 14, 2023 16:46
@mboukhalfa
Copy link
Member Author

/test-centos-e2e-feature-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from 109d81b to e9fb91e Compare June 14, 2023 20:39
@mboukhalfa
Copy link
Member Author

/test-centos-e2e-feature-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from e9fb91e to 527ef09 Compare June 16, 2023 05:54
@mboukhalfa
Copy link
Member Author

/test-centos-e2e-feature-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from 527ef09 to aad8d9a Compare June 16, 2023 06:17
@mboukhalfa
Copy link
Member Author

/test-centos-e2e-feature-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from aad8d9a to 7f51d94 Compare June 16, 2023 15:23
@mboukhalfa
Copy link
Member Author

/test-centos-e2e-feature-main

@mboukhalfa
Copy link
Member Author

/close

@mboukhalfa mboukhalfa closed this Jun 21, 2023
@mboukhalfa mboukhalfa reopened this Apr 9, 2024
@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch 2 times, most recently from fa8553c to a51c0a5 Compare April 9, 2024 15:42
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from a51c0a5 to 34a65d6 Compare April 9, 2024 16:20
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from 34a65d6 to 919cd17 Compare April 9, 2024 16:49
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch 2 times, most recently from 8c239af to a34e8a1 Compare April 10, 2024 11:12
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

2 similar comments
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

@mboukhalfa mboukhalfa closed this Apr 12, 2024
@mboukhalfa mboukhalfa reopened this Apr 12, 2024
@mboukhalfa
Copy link
Member Author

/retest metal3-ubuntu-e2e-feature-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from c9079ef to c7d3e8f Compare April 26, 2024 17:15
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from 0da9e82 to eb49591 Compare April 29, 2024 09:42
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

2 similar comments
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from eb49591 to 8012ca1 Compare April 30, 2024 09:29
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

2 similar comments
@smoshiur1237
Copy link
Member

/test metal3-centos-e2e-feature-test-main

@smoshiur1237
Copy link
Member

/test metal3-centos-e2e-feature-test-main

@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from 8012ca1 to 8721db5 Compare April 30, 2024 13:11
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from 8721db5 to f0c3186 Compare April 30, 2024 13:56
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from f0c3186 to f80656f Compare April 30, 2024 14:03
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

@mboukhalfa
Add md_remediation test
ad296d7 
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
@mboukhalfa mboukhalfa force-pushed the Add-healthcheck-test/mohammed branch from f80656f to ad296d7 Compare April 30, 2024 15:00
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

1 similar comment
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-feature-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

@mboukhalfa
Copy link
Member Author

the old remediation test failed
/test metal3-ubuntu-e2e-feature-test-main

kashifest
kashifest reviewed May 2, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
smoshiur1237
smoshiur1237 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smoshiur1237
Copy link
Member

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot merged commit 4aedbd3 into metal3-io:main May 2, 2024
19 of 20 checks passed
@metal3-io-bot metal3-io-bot deleted the Add-healthcheck-test/mohammed branch May 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mboukhalfa @metal3-io-bot @smoshiur1237 @lentzi90 @kashifest