Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Removing live-iso test #2041

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
This test is not related to CAPM3 its part of BMO. We have this one now in BMO(https://github.com/metal3-io/baremetal-operator/blob/main/test/e2e/live_iso_test.go), so lets remove it from here.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #1996

Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2024
@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

/test metal3-centos-e2e-integration-test-main

@mquhuy
Copy link
Member

mquhuy commented Oct 16, 2024

LGTM

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you for your work

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@metal3-io-bot metal3-io-bot merged commit 0a96a82 into metal3-io:main Oct 16, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the remove-live-iso/test branch October 16, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants