Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add release-1.4 related changes #949

Merged
merged 1 commit into from Apr 28, 2023
Merged

🌱 Add release-1.4 related changes #949

merged 1 commit into from Apr 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2023

This is an automated cherry-pick of #944

/assign kashifest

@ghost ghost mentioned this pull request Apr 28, 2023
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2023
@mboukhalfa
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@mboukhalfa mboukhalfa changed the title [release-1.4] 🌱 Add release-1.4 related changes 🌱 Add release-1.4 related changes Apr 28, 2023
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 6063b03 into metal3-io:release-1.4 Apr 28, 2023
@tuminoid
Copy link
Member

Before project-infra PR is in, no real tests are being run in release branch 1.4 btw. For this PR it is a benefit, but just a note.

@kashifest
Copy link
Member

Before project-infra PR is in, no real tests are being run in release branch 1.4 btw. For this PR it is a benefit, but just a note.

Also we need branch protection rules for release-1.4

@kashifest
Copy link
Member

/test-ubuntu-integration-release-1-4

@kashifest
Copy link
Member

/test-ubuntu-integration-release-1-4

checking if it can still trigger the test, because we need atleast one trigger for github to pick it up and then it could be added in the github branch protection.

@kashifest
Copy link
Member

/test-ubuntu-integration-release-1-4

checking if it can still trigger the test, because we need atleast one trigger for github to pick it up and then it could be added in the github branch protection.

Branch protection added

@tuminoid
Copy link
Member

Before project-infra PR is in, no real tests are being run in release branch 1.4 btw. For this PR it is a benefit, but just a note.

Also we need branch protection rules for release-1.4

They're now in place for CAPM3 and IPAM, but we need to get the project-infra change in, and get the test triggered to add it GH required tests, yes.

@mboukhalfa
Copy link
Member

We should merge the trigger update here https://gerrit.nordix.org/c/infra/cicd/+/18061 and start using e2e /test-ubuntu-e2e-integration-release-1-4 I do not see a need to update jjbs with ansible trigger on 1.4 since we are deprecating it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants