Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump golang to 1.23.7 #913

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Mar 6, 2025

Bump golang to 1.23.7.

We'll have bunch of dependencies requiring this soon due vulns fixed in it.

Bump golang to 1.23.7.

We'll have bunch of dependencies requiring this soon due vulns fixed in it.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

tuminoid commented Mar 6, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2025
@tuminoid
Copy link
Member Author

tuminoid commented Mar 6, 2025

/cherry-pick release-1.9 release-1.8
Picks cleanly, tested.

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9 release-1.8
Picks cleanly, tested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 632ddd9 into metal3-io:main Mar 6, 2025
15 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-golang-1.23.7 branch March 6, 2025 10:37
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.10 milestone Mar 6, 2025
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #914

In response to this:

/cherry-pick release-1.9 release-1.8
Picks cleanly, tested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

tuminoid commented Mar 6, 2025

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

/cherry-pick release-1.8

Why the cherry pick didn't work for two branches again like it used to? :(
@lentzi90 we did bumps to Prow recently, any ideas?

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #915

In response to this:

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

/cherry-pick release-1.8

Why the cherry pick didn't work for two branches again like it used to? :(
@lentzi90 we did bumps to Prow recently, any ideas?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Member

lentzi90 commented Mar 6, 2025

I wasn't aware it worked for two at a time. There isn't anything in the official announchements that would hint at a change but I haven't looked through the commits. Maybe there is something, or there could be some temporary issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants