Sync up #204
Merged
Sync up #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to increase the size of the esp image for downstream compatibility.
Sensor data collection was intended for an earlier use of the ironic-image and resulting ironic container image in order to supply data to prometheus about hardware that has not yet been deployed upon. Since the deicsion was made not to leverage the data, it seems pointless to collect sensor data. As such, disable sensor data collection.
An improvement for testing and customization, moving all the files we need to install in the main image to a file and having dnf read its content. This allows exotic compositions of sources, like urls and local dirs, without having to touch the Dockerfile.
This will allow to pass a custom list of packages to install during build time with very little effort.
metal3-io-bot
added
approved
elfosardo
approved these changes
Oct 13, 2020
|
/lgtm |
dtantsur
approved these changes
Oct 13, 2020
| @@ -58,7 +58,7 @@ enable_ssl_api = true | |||
| automated_clean = {{ env.IRONIC_AUTOMATED_CLEAN }} | |||
| # NOTE(dtantsur): keep aligned with [pxe]boot_retry_timeout below. | |||
| deploy_callback_timeout = 4800 | |||
| send_sensor_data = true | |||
| send_sensor_data = false | |||
There was a problem hiding this comment.
I don't think we should change this.
There was a problem hiding this comment.
shouldn't change it at all, or upstream?
| httpd-tools | ||
| ipmitool | ||
| iproute | ||
| iscsi-initiator-utils |
There was a problem hiding this comment.
I wonder why we have this, we don't use the iscsi deploy..
There was a problem hiding this comment.
iirc we did at one stage (at the very start), its probably historical
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins, dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test-integration |
derekhiggins
pushed a commit
to derekhiggins/ironic-image
that referenced
this pull request
Aug 11, 2021
Bug 1986238: Supermicro X12 fails to provision using Redfish BM HW Provisioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing up patches from the downstream (openshift) image to here.