Make sensor_data collection configurable #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
|
Can you make this configurable through the environment variables ? We might not want to have this enabled on all deployments |
Previously we disabled for some reason, but we had people using the ironic prometheus exporter in Metal3. Add a new env variable `SEND_SENSOR_DATA` that will be used to define if it will be enabled or not.
iurygregory
force-pushed
the
enable_sensor_data
branch
from
4f5da97
to
1ae194a
Compare
|
@maelk done |
iurygregory
changed the title
|
/test-integration |
|
/lgtm |
dtantsur
approved these changes
Oct 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Aug 20, 2021
Bug 1993078: Restore auth config to ironic-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we disabled for some reason, but we had people using
the ironic prometheus exporter in Metal3.
Add a new env variable
SEND_SENSOR_DATAthat will be used todefine if it will be enabled or not.