-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting sshkey and kernel params for debugging IPA #226
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The previous PR to do this is here #150 |
cc @maelk , includes a proposal to remove console=ttyS0 we had hardcoded in, and use IRONIC_KERNEL_PARAMS instead |
hey @derekhiggins are this method or any of the parameters documented anywhere? |
Nope, I'll add some. thanks |
Would you mind creating a PR in BMO to maintain the current behaviour when merging this change ? There's two deployment methods in BMO, through ironic-deployment folder and with tools/run_local_ironic.sh. both refer to a configmap that need to be updated . There is also one in metal3-dev-env, in the 03_* script. Would you be ok modifying those ? thank you |
Yup, my intention is that it would only be maintained for virtual environments, I'll update those |
/test-integration |
/hold until the behaviour is maintained via PR in other repos |
@@ -26,7 +26,7 @@ else | |||
fi | |||
|
|||
# Copy files to shared mount | |||
cp /tmp/inspector.ipxe /shared/html/inspector.ipxe | |||
render_j2_config /tmp/inspector.ipxe.j2 /shared/html/inspector.ipxe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handling of options below should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this, I'm not sure what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, github does not allow me to comment on the code a bit below. It has the remaining bits of the old approach to templating, they should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cp /tmp/dualboot.ipxe /shared/html/dualboot.ipxe
cp /tmp/uefi_esp.img /shared/html/uefi_esp.img
these lines? Those aren't templates
Needs rebase. metal3-io/baremetal-operator#736 should land soon. Anything else we need to keep current behaviour? |
Add IRONIC_KERNEL_PARAMS to set extra kernel params. Also remove console=ttyS0 as it can now be set with IRONIC_KERNEL_PARAMS where needed. Having it hardcoded results in Nothing being sent to the VGA console in real baremetal environments, making it difficult to debug problems.
rebase done, I'm not aware of anything else yet to merge to keep current behaviour. |
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
Bug 2014630: Update ironic to fix image provisioning fails with file name too long
No description provided.