Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unbound variable error in prepare-image #235

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

elfosardo
Copy link
Member

Also make build process fail if something goes wrong in prepare-image

Also make build process fail if something goes wrong in prepare-image
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2020
@andfasano
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@andfasano: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Member Author

/assign @maelk @derekhiggins

@derekhiggins
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@hardys
Copy link
Member

hardys commented Dec 19, 2020

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2020
@elfosardo
Copy link
Member Author

/test-integration

@metal3-io-bot metal3-io-bot merged commit 02555d9 into metal3-io:master Dec 21, 2020
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Nov 24, 2021
…ersion

Install specific version of scciclient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants