Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net-tools installation #248

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

elfosardo
Copy link
Member

Now that metal3-io/baremetal-operator#728 has
merged, we can remove net-tools installation command.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2021
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net-tools were installed for using netstat in scripts/runironic-api, that logic should also be removed

Now that metal3-io/baremetal-operator#728 has
merged, we can remove net-tools installation command and the netstat
entry in runironic-api.
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test-integration

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@maelk
Copy link
Member

maelk commented Mar 30, 2021

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@metal3-io-bot metal3-io-bot merged commit b06a48e into metal3-io:master Mar 30, 2021
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Jan 6, 2022
Bug 2032573: Update ironic to include latest major bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants