Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework runlogwatch.sh #289

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Rework runlogwatch.sh #289

merged 1 commit into from
Aug 3, 2021

Conversation

dtantsur
Copy link
Member

Currently it only waits for files in the first created directory because
of an infinite loop inside the "for" loop.

Currently it only waits for files in the first created directory because
of an infinite loop inside the "for" loop.
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2021
@dtantsur
Copy link
Member Author

/cc @elfosardo @andfasano
/test-integration

@fmuyassarov
Copy link
Member

/test-integration

1 similar comment
@dtantsur
Copy link
Member Author

/test-integration

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@zaneb
Copy link
Member

zaneb commented Aug 2, 2021

/lgtm

@elfosardo
Copy link
Member

/approve considering @zaneb lgtm as the official lgtm :)

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@metal3-io-bot metal3-io-bot merged commit 147e664 into metal3-io:master Aug 3, 2021
@dtantsur dtantsur deleted the logwatch branch August 3, 2021 12:21
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Aug 17, 2022
Merge from upstream metal3-io/ironic-image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants