Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customize base image #290

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Allow customize base image #290

merged 1 commit into from
Aug 9, 2021

Conversation

elfosardo
Copy link
Member

Introduce an ARG BASE_IMAGE that allows customizing the base image used
to build the container.
This can be useful for quickly changing base image for testing,
especially in automated setups.

@elfosardo
Allow customize base image
a472e33 
Introduce an ARG BASE_IMAGE that allows customizing the base image used
to build the container.
This can be useful for quickly changing base image for testing,
especially in automated setups.
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2021
@elfosardo
Copy link
Member Author

/test-integration

@dtantsur
Copy link
Member

dtantsur commented Aug 2, 2021

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2021
kirankt
kirankt approved these changes Aug 3, 2021
View reviewed changes
Copy link

@kirankt kirankt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@kirankt: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, kirankt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link
Member Author

/cc @fmuyassarov @dtantsur @bfournie @iurygregory

fmuyassarov
fmuyassarov reviewed Aug 9, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@fmuyassarov: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Member

bfournie commented Aug 9, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2021
@metal3-io-bot metal3-io-bot merged commit 7ed5715 into metal3-io:master Aug 9, 2021
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Aug 19, 2022
@openshift-merge-robot
Merge pull request metal3-io#290 from elfosardo/ironic-4-12-deps
d468eee 
Update dependencies for OCP 4.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@kirankt kirankt kirankt approved these changes

@bfournie bfournie Awaiting requested review from bfournie

@dtantsur dtantsur Awaiting requested review from dtantsur

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elfosardo @dtantsur @metal3-io-bot @bfournie @kirankt @fmuyassarov