Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to build image from source #324

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Follow-up to build image from source #324

merged 1 commit into from
Nov 30, 2021

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Nov 17, 2021 •
edited
Loading

addresses leftovers from #304

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2021
@elfosardo
Copy link
Member Author

/test-v1b1-integration

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2021
@elfosardo
Copy link
Member Author

/test-v1b1-integration

@elfosardo
Copy link
Member Author

/cc @dtantsur @fmuyassarov

@dtantsur
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2021
fmuyassarov
fmuyassarov approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@fmuyassarov: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, fmuyassarov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hardys
Copy link
Member

hardys commented Nov 30, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@metal3-io-bot metal3-io-bot merged commit 418385f into metal3-io:master Nov 30, 2021
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Dec 13, 2022
@openshift-merge-robot
Merge pull request metal3-io#324 from rhjanders/change-865388-4.12
71c242f 
[4.12] Bug OCPBUGS-2052: Fix setting boot related attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov approved these changes

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elfosardo @dtantsur @metal3-io-bot @hardys @fmuyassarov