Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move python3-pip install into patch-image script #364

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

elfosardo
Copy link
Member

It's not needed if not for the patch-image script, so install it only
when we run that script.

It's not needed if not for the patch-image script, so install it only
when we run that script.
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2022
@elfosardo
Copy link
Member Author

/test-v1b1-centos-integration
/test-v1b1-ubuntu-integration

@elfosardo
Copy link
Member Author

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also work fine, thanks @elfosardo!

@iurygregory
Copy link
Member

iurygregory commented Mar 21, 2022

/lgtm thanks Riccardo!

@iurygregory
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@metal3-io-bot metal3-io-bot merged commit 4a52bd0 into metal3-io:main Mar 21, 2022
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request May 10, 2023
Bug OCPBUGS-11753: Include Ironic code synced from upstream on 090523 in ironic-image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants