Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SECURITY_CONTACTS file #393

Merged
merged 1 commit into from
Nov 8, 2022
Merged

add SECURITY_CONTACTS file #393

merged 1 commit into from
Nov 8, 2022

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Nov 7, 2022

No description provided.

@Rozzii
Copy link
Member Author

Rozzii commented Nov 7, 2022

/cc @elfosardo

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2022
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2022
@Rozzii
Copy link
Member Author

Rozzii commented Nov 7, 2022

/test-ubuntu-integration-main

1 similar comment
@elfosardo
Copy link
Member

/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/retest

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@kashifest
Copy link
Member

/test-ubuntu-integration-main

/lgtm

@metal3-io-bot
Copy link
Contributor

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/test-ubuntu-integration-main

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rozzii
Copy link
Member Author

Rozzii commented Nov 7, 2022

/test-ubuntu-integration-main

1 similar comment
@Rozzii
Copy link
Member Author

Rozzii commented Nov 7, 2022

/test-ubuntu-integration-main

@iurygregory
Copy link
Member

Do we need test-ubuntu-integration-main for this?
I can apply the lgtm now if we don't need.

@Rozzii
Copy link
Member Author

Rozzii commented Nov 8, 2022

@iurygregory we don't need the ubuntu integration test, it is failing because of unrelated CI issues. Your lgtm would be much appreciated !

@iurygregory
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@dtantsur
Copy link
Member

dtantsur commented Nov 8, 2022

Force-merging since there is no point to run the CI.

@dtantsur dtantsur merged commit 661cff9 into metal3-io:main Nov 8, 2022
@Rozzii Rozzii deleted the security-contacts branch October 5, 2023 06:44
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Nov 8, 2023
@openshift-merge-robot
Merge pull request metal3-io#393 from elfosardo/no-unbound-varibles
fc1cca9 
OCPBUGS-17837: Fix PROVISIONING_MACS unbound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rozzii @elfosardo @metal3-io-bot @kashifest @iurygregory @dtantsur