Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix centos httpd #398

Merged
merged 1 commit into from
Nov 28, 2022
Merged

🐛 Fix centos httpd #398

merged 1 commit into from
Nov 28, 2022

Conversation

mboukhalfa
Copy link
Member

@mboukhalfa mboukhalfa commented Nov 25, 2022 •
edited
Loading

httpd-infra is not running correctly on centos because of PROVISIONING_MACS unbound value after inroducing bash set -u in #370

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022
@mboukhalfa
Copy link
Member Author

/test-ubuntu-integration-main

/test-centos-integration-main

@mboukhalfa
Copy link
Member Author

/test-centos-integration-main

@mboukhalfa mboukhalfa marked this pull request as ready for review November 25, 2022 17:00
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2022
@mboukhalfa mboukhalfa changed the title Fix centos httpd 🐛 Fix centos httpd Nov 25, 2022
@mboukhalfa
Copy link
Member Author

/assign @elfosardo

@mboukhalfa
Copy link
Member Author

/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2022
@kashifest
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

@bfournie,@derekhiggins, @dtantsur, @iurygregory we need lgtm here, the CI is stuck because of this.

furkatgofurov7
furkatgofurov7 reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekhiggins
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@metal3-io-bot metal3-io-bot merged commit 8f7ae55 into metal3-io:main Nov 28, 2022
@mboukhalfa mboukhalfa deleted the fix-centos-httpd/mohammed branch November 28, 2022 11:51
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Sep 18, 2023
@openshift-merge-robot
Merge pull request metal3-io#398 from derekhiggins/nomoretripleo
52af113 
OCPBUGS-19019: Switch from current-tripleo to puppet-passed-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@lentzi90 lentzi90 lentzi90 approved these changes

Assignees

@elfosardo elfosardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mboukhalfa @elfosardo @kashifest @metal3-io-bot @derekhiggins @lentzi90 @furkatgofurov7