Add Lennart and Adam as reviewers #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
|
/assign @elfosardo |
dtantsur
reviewed
Nov 28, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
kashifest
force-pushed
the
add/reviewers
branch
from
e3e5fda
to
688c18c
Compare
|
I would really love to skip tests on such changes :( |
|
/lgtm |
dtantsur
pushed a commit
to dtantsur/ironic-image
that referenced
this pull request
Oct 4, 2023
…ry-pick-398-to-release-4.14 [release-4.14] OCPBUGS-19083: Switch from current-tripleo to puppet-passed-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although, community guideline is to have 10 commits for a reviewer, this particular repository doesn't see that much commit on its own. I believe Lennart and Adam has necessary knowledge on this repo and they can be of help while reviewing codes in this repo.