Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum change to support inspection without inspector #443

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Minimum change to support inspection without inspector #443

merged 1 commit into from
Dec 1, 2023

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Nov 14, 2023 •
edited
Loading

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2023
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main

1 similar comment
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

Blocked on metal3-io/baremetal-operator#1446

@dtantsur dtantsur mentioned this pull request Nov 18, 2023
Closed
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2023
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main

1 similar comment
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2023
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

1 similar comment
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

@dtantsur dtantsur changed the title [WIP] Minimum change to support inspection without inspector Minimum change to support inspection without inspector Nov 30, 2023
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

Accidentally removed idrac-wsman from enabled interfaces, had to reupload.

@dtantsur
Minimum change to support inspection without inspector
490c751 
A lot more clean-up is possible, but this change allows testing
the new approach already.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@iurygregory
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@metal3-io-bot metal3-io-bot merged commit bea2325 into metal3-io:main Dec 1, 2023
5 checks passed
@dtantsur dtantsur deleted the no-inspector branch December 1, 2023 13:15
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Dec 20, 2023
@openshift-merge-bot
Merge pull request metal3-io#443 from dtantsur/sync
6a63297 
NO-ISSUE: Merge from metal3-io/ironic-image (33275f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtantsur @elfosardo @metal3-io-bot @iurygregory