Allow customizing conductor hostname #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
|
/test-ubuntu-integration-main |
|
/test-centos-integration-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
5 tasks
tuminoid
reviewed
Nov 27, 2023
In a distributed setup, conductor hostnames will be used for RPC. Currently, the IP address is used which may make TLS configuration much harder. With this change, certain tricks are possible, e.g. using pod DNS names (`<ip>.<namespace>.pod.cluster.local`) combined with a wildcard certificate (`*.<namespace>.pod.cluster.local`). See also metal3-io/ironic-standalone-operator#3 Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur
force-pushed
the
conductor-host
branch
from
8c48f30
to
a4f5ae5
Compare
|
/test-ubuntu-integration-main |
|
/test-centos-integration-main |
honza
pushed a commit
to honza/ironic-image
that referenced
this pull request
Jan 25, 2024
METAL-850: Update packages for OCP 4.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a distributed setup, conductor hostnames will be used for RPC.
Currently, the IP address is used which may make TLS configuration
much harder. With this change, certain tricks are possible, e.g. using
pod DNS names (
<ip>.<namespace>.pod.cluster.local) combined witha wildcard certificate (
*.<namespace>.pod.cluster.local).See also metal3-io/ironic-standalone-operator#3
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com