Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 reduce github actions permissions #471

Merged
merged 1 commit into from
Jan 15, 2024
Merged

🌱 reduce github actions permissions #471

merged 1 commit into from
Jan 15, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 8, 2024

Cleanup GH actions, and move permissions from top-level to job-level. Restrict job running to the main repository.

This restores token permission score to 10/10.

/hold
until metal3-io/ip-address-manager#408 is reviewed and merged as this is replication of that.

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2024

Holding until dependabot in IPAM with new permissions has been tested. It should have some PRs next Monday at latest.

@tuminoid
Copy link
Member Author

/hold
Waiting for #456 to merge first.

@elfosardo
Copy link
Member

/test-centos-integration-main
/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@tuminoid
reduce github actions permissions
5aa4d65 
Cleanup GH actions, and move permissions from top-level to job-level.
Restrict job running to the main repository.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@tuminoid
Copy link
Member Author

/unhold
Dependency was merged.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2024
@tuminoid
Copy link
Member Author

/override test-centos-integration-main test-ubuntu-integration-main
GH actions change, not relevant.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-integration-main test-ubuntu-integration-main
GH actions change, not relevant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cc @lentzi90 @Rozzii

lentzi90
lentzi90 reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@metal3-io-bot metal3-io-bot merged commit 0d9a740 into metal3-io:main Jan 15, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-gh-actions branch January 15, 2024 10:42
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Apr 18, 2024
@openshift-merge-bot
Merge pull request metal3-io#471 from elfosardo/bump-eventlet-version
c8eb5c4 
OCPBUGS-32162: Bump eventlet version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @elfosardo @metal3-io-bot @lentzi90