Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Read Ironic htpasswd from file or environment variable #506

Merged
merged 1 commit into from
Jun 4, 2024
Merged

🌱 Read Ironic htpasswd from file or environment variable #506

merged 1 commit into from
Jun 4, 2024

Conversation

MahnoorAsghar
Copy link
Contributor

This PR reverts #482 and #498, because it is not secure to mount the ironic username and password as plain text files into
ironic-image. The PR adds the ability to mount the ironic htpasswd as a file (to introduce a better way than just using environment variable for this purpose).

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2024
@MahnoorAsghar
Copy link
Contributor Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

1 similar comment
@Rozzii
Copy link
Member

Rozzii commented May 10, 2024

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@Rozzii
Copy link
Member

Rozzii commented May 10, 2024

I was not following this "username:password" topic for some time but I have also found interesting when I have noticed that the username and the password is in plain text so I agree with this PR, thanks!
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
lentzi90
lentzi90 reviewed May 10, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure seems to be just a timeout with 1 out of 11 succeeded. Retriggering
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
/approve

@Rozzii
Copy link
Member

Rozzii commented May 10, 2024

Need an approver
/cc @elfosardo

@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

3 similar comments
@MahnoorAsghar
Copy link
Contributor Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@MahnoorAsghar
Copy link
Contributor Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@MahnoorAsghar
Copy link
Contributor Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

/retest
CI should be better now.

@Rozzii
Copy link
Member

Rozzii commented May 17, 2024

/test metal3-centos-e2e-integration-test-main

@Rozzii
Copy link
Member

Rozzii commented May 27, 2024

/test metal3-centos-e2e-integration-test-main

tuminoid
tuminoid reviewed May 27, 2024
View reviewed changes
scripts/auth-common.sh Outdated Show resolved Hide resolved
scripts/auth-common.sh Outdated Show resolved Hide resolved
@Rozzii Rozzii mentioned this pull request May 29, 2024
Closed
@MahnoorAsghar
Read ironic htpasswd from file or env variable
d05e890 
Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@MahnoorAsghar
Copy link
Contributor Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@MahnoorAsghar
Copy link
Contributor Author

/test metal3-centos-e2e-integration-test-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@Rozzii
Copy link
Member

Rozzii commented Jun 4, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@metal3-io-bot metal3-io-bot merged commit 164ad23 into metal3-io:main Jun 4, 2024
8 checks passed
@MahnoorAsghar MahnoorAsghar deleted the read-htpasswd-m3-main branch June 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MahnoorAsghar @Rozzii @tuminoid @elfosardo @metal3-io-bot @dtantsur @lentzi90