🐛 Update httpd.conf.j2 #532
Conversation
metal3-io-bot
added
the
needs-ok-to-test
|
Hi @owenthomas17. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
metal3-io-bot
added
the
size/XS
| @@ -1,6 +1,6 @@ | |||
| ServerRoot "/etc/httpd" | |||
| {%- if env.LISTEN_ALL_INTERFACES | lower == "true" %} | |||
| Listen [::]:{{ env.HTTP_PORT }} | |||
| Listen {{ env.HTTP_PORT }} | |||
There was a problem hiding this comment.
Is this still listening on all interfaces ?
There was a problem hiding this comment.
looks like from the Apache docs
There was a problem hiding this comment.
Yes, according to the apache documentation:
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
|
Can you please sign the commit to fix the DCO ? and run tests ? |
The current `Listen` directive does not work on systems that have ipv6 disabled. The Apache Listen directive supports `Listen <port>` syntax at which point it seems to be able to listen correctly on both dual stack and ipv4 only systems. See https://httpd.apache.org/docs/2.4/bind.html for more details. Signed-off-by: Owen Thomas <owen@owen-thomas.co.uk>
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
/lgtm issue in the job doesn't seem related |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
failed because of http issue when installing packages |
|
/lgtm |
|
@mboukhalfa: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@iurygregory Can you please re-lgtm I do not have this permission on this repo ? |
|
/lgtm |
METAL-1094: Sync with upstream metal3-io/ironic-image
What this PR does / why we need it:
The current
Listendirective does not work on systems that have ipv6 disabled. The Apache Listen directive supportsListen <port>syntax at which point it seems to be able to listen correctly on both dual stack and ipv4 only systems. See https://httpd.apache.org/docs/2.4/bind.html for more details.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #531