🐛 Pin setuptools and pin upper-constraints #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
do-not-merge/work-in-progress
metal3-io-bot
added
the
size/XL
elfosardo
force-pushed
the
update-setuptools
branch
from
f7d98d0
to
5f78f9f
Compare
|
/test metal3-centos-e2e-integration-test-release-1-6 metal3-ubuntu-e2e-integration-test-release-1-6 |
|
/cc @dtantsur |
|
Oh we had forgotten to pin the requirements, ouch :) |
tuminoid
reviewed
Sep 24, 2024
Usually the setuptools installed by the system is stable but a bit too old compared to the packages we use for ironic, so pinning a more recent version helps avoiding errors and incompatibilities. Also pin upper-constraints since we forgot! Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
elfosardo
force-pushed
the
update-setuptools
branch
from
5f78f9f
to
54d741a
Compare
metal3-io-bot
removed
the
do-not-merge/work-in-progress
elfosardo
changed the title
|
/test metal3-centos-e2e-integration-test-release-1-6 metal3-ubuntu-e2e-integration-test-release-1-6 |
|
@dtantsur can you please have a look? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
iurygregory
pushed a commit
to iurygregory/ironic-image
that referenced
this pull request
Oct 18, 2024
OCPBUGS-39017: Bump ironic-lib to fix utf8 decoding issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the setuptools installed by the system is stable but
a bit too old compared to the packages we use for ironic,
so pinning a more recent version helps avoiding
errors and incompatibilities.
Also pin upper-constraints since we forgot!