Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a tagged image #52

Open
sathieu opened this issue Apr 16, 2024 · 12 comments
Open

Create a tagged image #52

sathieu opened this issue Apr 16, 2024 · 12 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@sathieu
Copy link
Contributor

sathieu commented Apr 16, 2024

Last release is 4 years old. Time to re-release?

@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Apr 16, 2024
@tuminoid
Copy link
Member

IPA downloader has not been part of the releases we make, instead we have been using the latest. All the old tags are pre-release tags as well, so this never had a release.

In #53 I'll add capability for creating a release image in case we do want to tag it.

@Rozzii suggests we use Ironic-image version for creating a matching release image from this repo (ie. v24.1.0). Any other thoughts? capm3-v.... tag style is outdated.

@elfosardo
Copy link
Member

to have tagged releases we should probably decide how to pin the ironic-python-agent used in the image and not just use the "master" branch
https://github.com/metal3-io/ironic-ipa-downloader/blob/main/get-resource.sh#L20

@Rozzii
Copy link
Member

Rozzii commented Apr 24, 2024

@elfosardo I would follow the same way as Ironic , so using the stable and bugfix branches as they come.

@dtantsur
Copy link
Member

The problem is: we don't publish IPA images for bugfix branches (for space and CI coverage reasons).

@Rozzii
Copy link
Member

Rozzii commented Apr 24, 2024

I don't think IPA have to be the same as Ironic branch usage wise. So if we have a stable ipa and no bugfix then we just go with the stable IPA. Advanced users would be able to overwrite it anyways if they would need some more recent IPA feature.

@Rozzii
Copy link
Member

Rozzii commented Apr 24, 2024

But in any case if we would do OCI labeling (and I think we should) we should have release branches with the pinned IPA branches and then official release. And I would change my original approach to use the IPA branch names as lablel and not the ironic release names.

@dtantsur
Copy link
Member

Advanced users would be able to overwrite it anyways if they would need some more recent IPA feature.

Works for me, but we'll need to be careful to avoid hard dependency on newer IPA in BMO.

@Rozzii
Copy link
Member

Rozzii commented Apr 24, 2024

/triage accepted
The goal of this ticket would be to create a design proposal, the implementation will depend on that, it is not so strait forward now that I have had some more discussion about the topic.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 24, 2024
@Rozzii Rozzii moved this from Backlog to MISC on hold / blocked in Metal3 - Roadmap Jun 28, 2024
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2024
@Rozzii
Copy link
Member

Rozzii commented Jul 24, 2024

/remove-lifecycle stale
There have been a few rounds of discussion around this IPA downloader, we hadn IMO a good discussion about this issue on the 2024 June 12th Community meeting https://www.youtube.com/watch?v=XJ0NqJEriWY&t=8s .

The conclusion is that the most likely roadmap is:

  • we start "releasing" IPA images at some point, we already moved the IPA builder scripts into the project-infra repo and the fullstack CI job is already building IPA images. What we need to do IMO is to start pinning the IPA versions in the IPA builder in a file or in the shell script and create a tag , build the image and store it on the project's Artifactory page where we store the IPA images already.
  • After we have IPA "releases" then we can create a release branch for ipa-downloader and create proper github releases for the IPA downloader where we change the default IPA url to the one that we have built.

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2024
@tuminoid
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Status: MISC on hold / blocked
Development

No branches or pull requests

6 participants