Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags as triggers for image builds #53

Merged

Conversation

tuminoid
Copy link
Member

We currently only build main branch, and no tags. Add tag support.

We currently only build main branch,  and no tags. Add tag support.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2024
@tuminoid
Copy link
Member Author

/override test-centos-integration-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main

In response to this:

/override test-centos-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cc @dtantsur @elfosardo @zaneb @kashifest @Rozzii

We want to build a release tag for this too (version matching Ironic-image), and need to add the tag as trigger. PTAL.

Related to #52

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tuminoid tuminoid mentioned this pull request Apr 17, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Collaborator

@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

/test ?

@metal3-io-bot
Copy link
Collaborator

@kashifest: The following commands are available to trigger required jobs:

  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test shellcheck

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-integration-test-release-1-4
  • /test metal3-centos-e2e-integration-test-release-1-5
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-release-1-4
  • /test metal3-ubuntu-e2e-integration-test-release-1-5
  • /test metal3-ubuntu-e2e-integration-test-release-1-6

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

Running prow CI to make it visible to branch protection
/test metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member Author

/override metal3-centos-e2e-integration-test-main
This is not relevant, just unrelated test.

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
This is not relevant, just unrelated test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

@elfosardo @dtantsur can we merge this, it is just enabler and doesn't do anything by itself.

@elfosardo
Copy link
Member

@tuminoid yes, looks ok

@tuminoid
Copy link
Member Author

@tuminoid yes, looks ok

Can I then have an /approve or /lgtm too 😉

@elfosardo
Copy link
Member

/approve

sorry, I thought I added it!

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@tuminoid
Copy link
Member Author

/assign @dtantsur

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Collaborator

@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member Author

tuminoid commented May 6, 2024

Ping @dtantsur

@tuminoid
Copy link
Member Author

/cc @zaneb

@Rozzii
Copy link
Member

Rozzii commented May 14, 2024

/lgtm

@metal3-io-bot
Copy link
Collaborator

@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@metal3-io-bot metal3-io-bot merged commit b412cdf into metal3-io:main May 15, 2024
4 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-tag-support-for-image-building branch May 15, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants