-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tags as triggers for image builds #53
add tags as triggers for image builds #53
Conversation
We currently only build main branch, and no tags. Add tag support. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
/override test-centos-integration-main |
@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @dtantsur @elfosardo @zaneb @kashifest @Rozzii We want to build a release tag for this too (version matching Ironic-image), and need to add the tag as trigger. PTAL. Related to #52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test ? |
@kashifest: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Running prow CI to make it visible to branch protection |
/override metal3-centos-e2e-integration-test-main |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@elfosardo @dtantsur can we merge this, it is just enabler and doesn't do anything by itself. |
@tuminoid yes, looks ok |
Can I then have an /approve or /lgtm too 😉 |
/approve sorry, I thought I added it! |
/assign @dtantsur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, kashifest, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ping @dtantsur |
/cc @zaneb |
/lgtm |
@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
We currently only build main branch, and no tags. Add tag support.