⚠️ Rework naming of references in the API #92
Conversation
metal3-io-bot
added
the
size/L
|
/hold I'll create a corresponding metal3-dev-env change. |
metal3-io-bot
added
the
do-not-merge/hold
|
metal3-io/metal3-dev-env#1478 pins IrSO to avoid breaking metal3-dev-env with this. |
|
/hold cancel |
metal3-io-bot
removed
the
do-not-merge/hold
We absolutely should not make life difficult for ourselves here, this is pre-MVP. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
As discussed in metal3-io#91, lets use simpler reference names and reserve the SomethingRef format for when the field can refer to different kinds or at least namespaces. This is quite a breaking change but I don't see a lot of value in going through deprecation since it's going to significantly complicate the code nobody should be using in production yet. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
metal3-io-bot
removed
the
needs-rebase
|
best do a change like this now /lgtm |
As discussed in
#91, lets
use simpler reference names and reserve the SomethingRef format for when
the field can refer to different kinds or at least namespaces.
This is quite a breaking change but I don't see a lot of value in going
through deprecation since it's going to significantly complicate the
code nobody should be using in production yet.
Closes: #91
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com