fix ironic building from source in PR test #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a PR, repo being tested is cloned as tested_repo. This doesn't match "ironic-image" like it normally would, and Ironic is not built from soruce. Same issue with CAPI. Identify the local image via the prefix of the LOCAL_IMAGE variable rather than the variable content (repo path). Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
metal3-io-bot
added
the
size/XS
|
/test-ubuntu-integration-main |
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
|
/test-centos-integration-release-1-5 |
metal3-io-bot
added
the
do-not-merge/hold
Rozzii
approved these changes
Dec 22, 2023
|
/hold cancel |
metal3-io-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a PR CI test, repo having the change and being tested is cloned as
/path/to/tested_repo. This doesn't matchronic-imagedirectory like it normally would, and causes Ironic image to not be built from soruce. Same issue with CAPI. Identify the local image via the prefix of theXXX_LOCAL_IMAGEvariable rather than the variable content (repo path).