Add option to skip apply BMHs #1463
Conversation
metal3-io-bot
added
the
size/M
|
/test metal3-dev-env-integration-test-ubuntu-main metal3-centos-e2e-integration-test-release-1-8 |
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
mboukhalfa
force-pushed
the
Add-option-to-skip-applying-bmhs/mohammed
branch
from
166e7a2
to
c4bcf5b
Compare
| # then dev-env will create the bmh files but do not apply tehm | ||
| if [[ "${SKIP_APPLY_BMH:-false}" == "true" ]]; then | ||
| pushd "${BMOPATH}" | ||
| list_nodes | make_bm_hosts |
There was a problem hiding this comment.
We should move make_bm_hosts also to capm3. Perhaps in next step.
There was a problem hiding this comment.
feel free to create an issue
|
/lgtm |
|
@adilGhaffarDev: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal3-dev-env-integration-test-ubuntu-main |
|
/test metal3-centos-e2e-integration-test-release-1-8 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smoshiur1237, Sunnatillo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test metal3-centos-e2e-integration-test-release-1-8 |
Part of : #1383
Next step use this option in tests to skip applying BMHs in DEV-ENV
makeand apply them in the tests