Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Drop CentOS8.3 and move to CentOS Stream #707

Merged
merged 1 commit into from
Jul 1, 2021
Merged

✨Drop CentOS8.3 and move to CentOS Stream #707

merged 1 commit into from
Jul 1, 2021

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Jun 21, 2021 •
edited
Loading

This is the second try to move to CentOS Stream in metal3-dev-env.

Fixes: #671

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2021
@furkatgofurov7 furkatgofurov7 changed the title ✨ WIP: Drop CentOS8.3 and move to CentOS Stream WIP: ✨Drop CentOS8.3 and move to CentOS Stream Jun 21, 2021
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2021
@furkatgofurov7
Copy link
Member Author

/test-v1a4-centos-integration

@furkatgofurov7 furkatgofurov7 force-pushed the use-centos-stream/furkat branch 3 times, most recently from a31d18c to 52b27e4 Compare June 28, 2021 19:13
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jun 29, 2021
Closed
@furkatgofurov7 furkatgofurov7 force-pushed the use-centos-stream/furkat branch 2 times, most recently from c514792 to 25f89a9 Compare June 29, 2021 22:19
@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Jun 29, 2021 •
edited
Loading

/hold
/retitle ✨Drop CentOS8.3 and move to CentOS Stream

It needs airship#327 to go in first to build metal3/node centos images and pass centos integration/feature tests.
Since we need node images with different k8s versions (v1.21.1 and v1.21.2) for feature/integration tests, node image with k8s version v1.21.1 (CENTOS_8_NODE_IMAGE_K8S_v1.21.1.qcow2) has been built and pushed to nordix artifactory with same modifications as in airship#327, and node image with k8s version v1.21.2 will be built once airship#327 is merged and node image builing Jenkins job run.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2021
@metal3-io-bot metal3-io-bot changed the title WIP: ✨Drop CentOS8.3 and move to CentOS Stream ✨Drop CentOS8.3 and move to CentOS Stream Jun 29, 2021
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2021
@furkatgofurov7
Copy link
Member Author

/assign @kashifest
/cc @elfosardo

@furkatgofurov7
Copy link
Member Author

/test-integration

@furkatgofurov7
Copy link
Member Author

airship#327 is merged and images are built, triggering the tests.

/test-v1a4-centos-integration
/test-centos-integration
/test-features-centos

@furkatgofurov7
Copy link
Member Author

/cc @fmuyassarov

@macaptain
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021
@smoshiur1237
Copy link
Member

/lgtm

fmuyassarov
fmuyassarov reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@furkatgofurov7
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2021
@metal3-io-bot metal3-io-bot merged commit c508a7a into metal3-io:master Jul 1, 2021
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jul 6, 2021
Merged
@furkatgofurov7 furkatgofurov7 deleted the use-centos-stream/furkat branch July 6, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@lentzi90 lentzi90 lentzi90 approved these changes

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from CentOS8 to CentOS Stream distribution
7 participants
@furkatgofurov7 @macaptain @smoshiur1237 @metal3-io-bot @lentzi90 @fmuyassarov @kashifest