Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify which serviceAccount the agent pod uses #2876

Closed
dbeilin opened this issue Oct 28, 2024 · 7 comments
Closed

Add the ability to specify which serviceAccount the agent pod uses #2876

dbeilin opened this issue Oct 28, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@dbeilin
Copy link
Contributor

dbeilin commented Oct 28, 2024

In addition to this PR which added support for a nodeSelector, I think specifying a SA would also be beneficial, instead of having the agent pod start with the default SA.

If this is something you'd approve of, I'm willing to give it a go and open a PR for it.

@dbeilin dbeilin added the enhancement New feature or request label Oct 28, 2024
Copy link

linear bot commented Oct 28, 2024

@aviramha
Copy link
Member

aviramha commented Oct 28, 2024

Thanks for the suggestion and appreciate the willingness to contribute :)
I think it's okay.. @Razz4780 wdyt? My only concern would be to make sure when using the operator it is controlled by it (and not by the user, to avoid security concerns)

@Razz4780
Copy link
Contributor

Yeah, I think it's ok. Thanks for willingness to contribute ^^
As for the operator - tbh I don't have any concerns, since agent config is controlled from the operator. Why would we need to check who controls the service account?

@aviramha
Copy link
Member

Yeah, I think it's ok. Thanks for willingness to contribute ^^ As for the operator - tbh I don't have any concerns, since agent config is controlled from the operator. Why would we need to check who controls the service account?

I don't think we'd need to do it - just saying that we need to make sure that this will be under the agent config and will not somehow affect via operator.

@Razz4780
Copy link
Contributor

Ah, ok. All good then

@dbeilin
Copy link
Contributor Author

dbeilin commented Oct 28, 2024

Thanks guys, I created the PR.

@dbeilin
Copy link
Contributor Author

dbeilin commented Oct 28, 2024

Thanks for merging 😄

@dbeilin dbeilin closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants