Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serviceAccount option to agent config #2877

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

dbeilin
Copy link
Contributor

@dbeilin dbeilin commented Oct 28, 2024

Added the option to specify a serviceAccount in the config file as mentioned here.

@dbeilin
Copy link
Contributor Author

dbeilin commented Oct 28, 2024

The schema_file_is_up_to_date test keeps failing for me, even though the comment in agent.rs and the schema file seems to match exactly. Maybe I'm missing a whitespace or a new-line somewhere, but I couldn't figure it out. I'd appreciate your help on this one 😢

@Razz4780
Copy link
Contributor

The schema_file_is_up_to_date test keeps failing for me, even though the comment in agent.rs and the schema file seems to match exactly. Maybe I'm missing a whitespace or a new-line somewhere, but I couldn't figure it out. I'd appreciate your help on this one 😢

How did you update the schema? We're usually run cargo test -p mirrord-config check_schema_file_exists_and_is_valid_or_create_it -- --ignored --nocapture to update it

@dbeilin
Copy link
Contributor Author

dbeilin commented Oct 28, 2024

I was manually creating it 💀 😭
schema_file_is_up_to_date passes now, thanks!

@Razz4780 Razz4780 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into metalbear-co:main with commit 33503a0 Oct 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants