Use metrics for readiness/liveness probes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
force-pushed
the
remove_healthz
branch
from
a9d327e to
a8f3403
Compare
oribon
changed the title
oribon
force-pushed
the
remove_healthz
branch
from
a8f3403 to
464ed2d
Compare
Since the existing healthz/readyz don't do much, we leverage the existing metrics endpoint for the probes to avoid opening another port (8081) on the host. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
oribon
force-pushed
the
remove_healthz
branch
from
464ed2d to
5b13edb
Compare
oribon
changed the title
|
I guess metallb's prometheus rules will need to be changed accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the existing healthz/readyz don't do much, we leverage the metrics endpoints for readiness/liveness to avoid opening another port (8081) on the host.
Is this a BUG FIX or a FEATURE ?:
/kind cleanup
What this PR does / why we need it:
Special notes for your reviewer:
Release note: