Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: bump e2etest version and use new field #239

Closed
wants to merge 1 commit into from

Conversation

karampok
Copy link
Contributor

With the new version we need to change the .IP of the neighbor to .ID. The struct in metallb/e2etest looks as follows:

type Neighbor struct {
	// ID is the key that vtysh returns for the neighbor,
	// it can be either IP or interface name if unnumbered.
	ID                      string
	VRF                     string

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind failing

/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE

With the new version we need to change the .IP of the neighbor to .ID.
The struct in metallb/e2etest looks as follows:

```
type Neighbor struct {
	// ID is the key that vtysh returns for the neighbor,
	// it can be either IP or interface name if unnumbered.
	ID                      string
	VRF                     string
```

Signed-off-by: karampok <karampok@gmail.com>
@karampok
Copy link
Contributor Author

@oribon this is needed because of the change we did on the other repo about .IP to become .ID and string.
Thanks!

@karampok karampok marked this pull request as ready for review December 12, 2024 11:41
@karampok
Copy link
Contributor Author

Given there are some other changes in the go.mod,
I bump as follow

#fix the go.mod to look to main
        go.universe.tf/e2etest => github.com/metallb/metallb/e2etest  main

and execute go mod tidy which fixes the version but as side effect some other stuff are needed.

@karampok
Copy link
Contributor Author

As @oribon suggested that to be merged either with the #212 or with #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant