Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize() has to be run on the linksets to convert their "date" option to a function #48

Comments

@rse
Copy link

rse commented Jan 2, 2016

When using the recently introduced linksets feature, an error is given: "TypeError: options.date is not a function". This is because normalize() internally is not called on the linksets. As a quickfix I've added find(linksets, function(ls) { normalize(ls) }) below the line var linksets [...] in function plugin [...]. Please either apply this fix or make an alternative one. But without this using the linksets feature is broken AFAIK.

@misterdai
Copy link

Just ran into this as well myself. Really does need looking at, I've waited ages for permalinks to support collections, finally spotted that it's been added with multiple linksets and now there's another roadblock in the way.

arccoza added a commit to arccoza/metalsmith-permalinks that referenced this issue Mar 9, 2016
@arccoza
Copy link

arccoza commented Mar 9, 2016

I had the same experience, a simple patch to normalize fixes the problem, #55.

@aliok
Copy link

aliok commented Mar 9, 2016

👍 Same problem here.

arccoza added a commit to arccoza/metalsmith-permalinks that referenced this issue Mar 28, 2016
Fix metalsmith#48, a simple patch to normalize() linksets.
dochang added a commit to dochang/metalsmith-permalinks that referenced this issue Apr 21, 2016
@ringods
Copy link

ringods commented Sep 29, 2016

There are 3 pull requests related to this issue: #54, #55 and #56.

Can one of them be merged please, followed by a new release?

@ringods
Copy link

ringods commented Oct 9, 2016

@ianstormtaylor or @lambtron, would you mind having a look at this?
Or accept some additional maintainers to this repo?

@mahnunchik
Copy link

@ianstormtaylor @lambtron ping

@patdavid
Copy link

patdavid commented Feb 1, 2017

Just ran into this myself, adding support for merging one of the PR's that fixes it, pretty please? :)

@misterdai
Copy link

Nothing back on this issue for quite a while. Starting to think it's not a priority for them anymore.

@mahnunchik
Copy link

@ianstormtaylor @lambtron any news?

dochang added a commit to dochang/metalsmith-permalinks that referenced this issue Jul 21, 2018
@sambonbonne
Copy link

sambonbonne commented Feb 20, 2019

Hi,
Sorry to "re-open" this issue (which wasn't closed) but I ran into this too with metalsmith-permalinks 2.1.0. Is it possible to fix this with one of the proposed PR?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment