-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize() has to be run on the linksets to convert their "date" option to a function #48
normalize() has to be run on the linksets to convert their "date" option to a function #48
Comments
Just ran into this as well myself. Really does need looking at, I've waited ages for permalinks to support collections, finally spotted that it's been added with multiple linksets and now there's another roadblock in the way. |
I had the same experience, a simple patch to |
👍 Same problem here. |
Fix metalsmith#48, a simple patch to normalize() linksets.
@ianstormtaylor or @lambtron, would you mind having a look at this? |
@ianstormtaylor @lambtron ping |
Just ran into this myself, adding support for merging one of the PR's that fixes it, pretty please? :) |
Nothing back on this issue for quite a while. Starting to think it's not a priority for them anymore. |
@ianstormtaylor @lambtron any news? |
Hi, |
When using the recently introduced linksets feature, an error is given: "TypeError: options.date is not a function". This is because normalize() internally is not called on the linksets. As a quickfix I've added
find(linksets, function(ls) { normalize(ls) })
below the linevar linksets [...]
infunction plugin [...]
. Please either apply this fix or make an alternative one. But without this using the linksets feature is broken AFAIK.The text was updated successfully, but these errors were encountered: