-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc comment edits #2828
Misc comment edits #2828
Conversation
…x for commands of the metamath program
Proposal: relabel ~a1tru to ~imtru since it is dual to ~falim and the label is more informative. |
@avekens : what about the label change proposal (see comment above) ? |
On the one hand, the label ~imtru is better than ~a1tru. On the other hand, it should be named ~trud, because it follows our rules for deduction style. The currently named theorem ~trud is not in deduction form, therefore this theorem should be renamed... |
I propose: |
OK
Do you really like "trump"? ;-) Nevertheless, what about ~mptru, like ~mpbi ("biimpi" followed by ax-mp)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the label changes shoud be documented in changes-set.txt
The label changes themselves are OK. |
I'm not sure that If we do rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, everything is fine now - but we should consider David's concerns...
@david-a-wheeler @avekens : I'm going to add an issue to (We finally chose " |
I don't think we should compromising our naming conventions because of some coincidences with modern politics and/or playing cards. That said, I don't think that |
It's kind of a modus ponens since from the major premise The convention following intro/elim is nice, but mixing different conventions can become a bit messy. That said, if you really think |
As far as naming goes,
|
Well, I liked |
Sometimes you have to bikeshed. This particular theorem is widely used, so we probably should try to make a "good choice". Maybe we should raise this to the mailing list for discussion? May as well maximize the bikeshedding :-). |
We usually don't, but we do use im in cases where there's almost nothing else to describe it. It wouldn't be a unique case, it's specifically documented already.
|
(see commit messages)