All Ruby filesystem system calls should be replaced with FileUtils

[ronaldtse]

system mkdir ...
system cp ...
system rm ...

=>
https://ruby-doc.org/stdlib-2.4.1/libdoc/fileutils/rdoc/FileUtils.html

require 'fileutils'
FileUtils.cd(dir, options)
FileUtils.cd(dir, options) {|dir| block }
FileUtils.pwd()
FileUtils.mkdir(dir, options)
FileUtils.mkdir(list, options)
FileUtils.mkdir_p(dir, options)
FileUtils.mkdir_p(list, options)
FileUtils.rmdir(dir, options)
FileUtils.rmdir(list, options)
FileUtils.ln(target, link, options)
FileUtils.ln(targets, dir, options)
FileUtils.ln_s(target, link, options)
FileUtils.ln_s(targets, dir, options)
FileUtils.ln_sf(target, link, options)
FileUtils.cp(src, dest, options)
FileUtils.cp(list, dir, options)
FileUtils.cp_r(src, dest, options)
FileUtils.cp_r(list, dir, options)
FileUtils.mv(src, dest, options)
FileUtils.mv(list, dir, options)
FileUtils.rm(list, options)
FileUtils.rm_r(list, options)
FileUtils.rm_rf(list, options)
FileUtils.install(src, dest, options)
FileUtils.chmod(mode, list, options)
FileUtils.chmod_R(mode, list, options)
FileUtils.chown(user, group, list, options)
FileUtils.chown_R(user, group, list, options)
FileUtils.touch(list, options)

[opoudjis]

I can't do anything about the invokation of node.js for puppetteer:

        system "export NODE_PATH=$(npm root --quiet -g);
                node #{pdfjs} file://#{url} #{filename}.pdf"

Manipulating the environment PATH variable is still going to be needed for Windows.

Likewise the invocation of plantuml

[opoudjis]

Have done all other instances of system with FileUtils. Close ticket?

[ronaldtse]

Thanks @opoudjis ; are all instances of system across the Metnaorma system all replaced with FileUtils?

There's nothing much we can do with puppeteer / plantuml for now.

[opoudjis]

All except for the calls to puppeteer and plantuml. I have not yet released gems for this change.