Run Gemfile.devel in Github Actions with metanorma-cli

[opoudjis]

As alerted in metanorma/isodoc#546 , Gemfile.devel is ignored in GitHub Actions when running metanorma-cli. Alex has done some fixes, which have made it possible for the metanorma-cli spec file to run correctly with the Gemfile.devel branches of underlying gems. But the samples it contains are still being run with the main branch as far as I can tell: they are crashing in the XSLT preprocessing line of the main branch of isodoc, which is different from the corresponding line in the branch of isodoc named in Gemfile.devel.

As I have found in my own running of metanorma-cli, any system calls to metanorma need to be put as bundle exec metanorma, in order to pick up the Gemfile.devel; it may also be that the system calls are not picking up Gemfile.devel in their environment.

I am doing a new release which may address the bug I'm trying to rectify; but the ability to run samples with branches named in Gemfile.devel in GitHub Actions remains a requirement. Especially if the fix I'm working with fails.

[CAMOBAP]

As I have found in my own running of metanorma-cli, any system calls to metanorma need to be put as bundle exec metanorma, in order to pick up the Gemfile.devel; it may also be that the system calls are not picking up Gemfile.devel in their environment.

According to my understanding we have to avoid any system("metanorma ...") calls in specs

But the samples it contains are still being run with the main branch

Sorry I completely missing this part, i'm not sure how easy it will be to automate it, but let me try

[opoudjis]

According to my understanding we have to avoid any system("metanorma ...") calls in specs

Perhaps, but it's not my code, it's @abunashir ’s, and I'm disinclined to be the one to fix it. And the point of this spec is to test that the system call to metanorma is working.

[CAMOBAP]

Samples/templates testing now should take in account Gemfile.devel restarting CI

Update: link to the run https://github.com/metanorma/metanorma-cli/actions/runs/6963118635

[CAMOBAP]

Test failed, one more update required, will rerun CI soon

Update: link to the run https://github.com/metanorma/metanorma-cli/actions/runs/6963118635

[opoudjis]

It's working, as I confirmed last night. Ticket stays open until the various random errors on running template also go away.

[opoudjis]

The new issue with templates appears to be mostly 2.7, and GHA hanging at:

  if [ "3.2" = "2.7" ]; then
    gem install lightly -v 0.3.3
  fi
  gem install metanorma-cli

https://github.com/metanorma/metanorma-cli/actions/runs/7011812490

[ronaldtse]

As a matter of principle I think version constraints must be stated in the gemspec, not in build scripts.

[CAMOBAP]

This one was a workaround which I hope can be removed already, I will do after release

[opoudjis]

@CAMOBAP can this issue close?

[CAMOBAP]

@opoudjis I hope so