Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #316

Merged
merged 10 commits into from
Nov 27, 2023
Merged

test #316

merged 10 commits into from
Nov 27, 2023

Conversation

opoudjis
Copy link
Contributor

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Nov 21, 2023
# COMMENT context "with -r option specified" do
# context is ignoring the needed "bundle install", and therefore can GO TO HELL. REMOVED.
# moving this text to end of suite instead
=begin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use block comments.

@@ -181,6 +171,23 @@
compile_doc(source_file, "-t iso -x xml,doc --no-progress")
end

# COMMENT context "with -r option specified" do
# context is ignoring the needed "bundle install", and therefore can GO TO HELL. REMOVED.
# moving this text to end of suite instead
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation detected (column 2 instead of 0).

@@ -181,6 +171,23 @@
compile_doc(source_file, "-t iso -x xml,doc --no-progress")
end

# COMMENT context "with -r option specified" do
# context is ignoring the needed "bundle install", and therefore can GO TO HELL. REMOVED.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [91/80]

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12786d1) 95.87% compared to head (f4d1423) 95.87%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          15       15           
  Lines         703      703           
=======================================
  Hits          674      674           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if File.exist? "Gemfile.devel"
eval File.read("Gemfile.devel"), nil, "Gemfile.devel" # rubocop:disable Security/Eval
end
eval_gemfile("Gemfile.devel") rescue nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using rescue in its modifier form.

@opoudjis opoudjis merged commit 16b70d6 into main Nov 27, 2023
46 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants