Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term rendering with concept mentions broken in style, instead of issuing warning of missing reference #170

Closed
ronaldtse opened this issue Nov 11, 2022 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link

Notice how the "scene graph" term has its definition messed up.

Screen Shot 2022-11-11 at 5 51 29 PM

==== scene graph

Encoded graph that contain information about {{scene,scenes}}, {{hyperspace asset,assets}}, {{authority,authorities}} and {{action,actions}}.


==== scene graph server

Server that contains primary and subordinate {{scene graph,scene graphs}}.

NOTE: Different servers may contain different parts of the same scene (for instance, the Earth scene, which hosts any form of augmented reality scenes, has potentially millions of scenes broken down by nested geopolitical regions or corporate environments). Unmoored scenes (such as those associated with game or simulation worlds that aren't based on real Earth location) may be similarly segmented.

related:seealso[scene graph]
@ronaldtse ronaldtse added the bug Something isn't working label Nov 11, 2022
@ronaldtse ronaldtse moved this to 🆕 New in Metanorma Nov 11, 2022
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Nov 11, 2022
@opoudjis
Copy link
Contributor

The bug involves four cross references. You have not provided any of them. I therefore cannot debug this.

This issue will be ignored until you provide the source document. Your ongoing failure to provide sufficient information for actionable issues is going to continue to get the same response.

@opoudjis opoudjis moved this from 🌋 Urgent to On hold in Metanorma Nov 11, 2022
@ronaldtse
Copy link
Author

@ronaldtse
Copy link
Author

I forgot to mention that PDF layout works perfectly.

@opoudjis opoudjis moved this from On hold to 🏗 In progress in Metanorma Nov 11, 2022
@opoudjis
Copy link
Contributor

There is no such term as "hyperspace asset".

AsciiDoc Input: (XML Line 000794): Error: Term reference to `hyperspace-asset` missing: "hyperspace-asset" is not defined in document

@opoudjis
Copy link
Contributor

We should break rendering, as with Standoc:

Error: Term reference to `#{target}` missing: "#{target}" is not defined in document

Need to establish why this isn't happening in IEEE.

@opoudjis opoudjis changed the title (URGENT) Term rendering with concept mentions broken Term rendering with concept mentions broken in style, instead of issuing warning of missing reference Nov 11, 2022
@opoudjis opoudjis moved this from 🏗 In progress to 🏔 High priority in Metanorma Nov 11, 2022
@opoudjis
Copy link
Contributor

opoudjis commented Nov 12, 2022

This is happening because we left it open when a term is not cited in an IEEE document, that it might be cited from the IEEE online dictionary.

But concept markup should not be used for such external references, when it presupposes for concept markup that the term is defined internally by default (which is what is happening here). If a cross-reference is given to a term, it should be explicit. So an error still needs to be displayed.

@opoudjis opoudjis moved this from 🏔 High priority to 🏗 In progress in Metanorma Nov 12, 2022
@opoudjis
Copy link
Contributor

No, changed my mind again. Those pending definitions to external and absent terms are legit.

@opoudjis
Copy link
Contributor

Need to get rid of intrusive spaces around concepts, inherited from pretty-printing.

Repository owner moved this from 🏗 In progress to ✅ Done in Metanorma Nov 14, 2022
@opoudjis opoudjis reopened this Nov 22, 2022
Repository owner moved this from ✅ Done to 🏗 In progress in Metanorma Nov 22, 2022
@opoudjis
Copy link
Contributor

Removed redundant spaces from the wrong place. They are being introduced in termdefinition processing.

@opoudjis
Copy link
Contributor

opoudjis commented Nov 22, 2022

to_xml as invoked in isodoc needs to use Nokogiri::XML::Node::SaveOptions::AS_XML a lot more, to prevent XML from being rendered with carriage returns between tags.

opoudjis added a commit to metanorma/isodoc that referenced this issue Nov 22, 2022
opoudjis added a commit that referenced this issue Nov 22, 2022
@opoudjis
Copy link
Contributor

Στιγμιότυπο 2022-11-22, 23 47 31

opoudjis added a commit to metanorma/metanorma-generic that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/isodoc that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-bipm that referenced this issue Nov 22, 2022
opoudjis added a commit that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-csa that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-generic that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-bipm that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-cc that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-iec that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-ietf that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-csa that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-iso that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-itu that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-cc that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-iec that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-ietf that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-ribose that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-un that referenced this issue Nov 22, 2022
Repository owner moved this from 🏗 In progress to ✅ Done in Metanorma Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-iso that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-itu that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-ribose that referenced this issue Nov 22, 2022
opoudjis added a commit to metanorma/metanorma-un that referenced this issue Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants