Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When :draft: is not present, do not show "XX Stage" #241

Closed
ronaldtse opened this issue Nov 19, 2018 · 10 comments
Closed

When :draft: is not present, do not show "XX Stage" #241

ronaldtse opened this issue Nov 19, 2018 · 10 comments
Assignees
Labels

Comments

@ronaldtse
Copy link
Contributor

When :draft: is not present, do not show "XX Stage" (the draft warning is already hidden correctly).

@opoudjis
Copy link
Contributor

...!

I'm really surprised to see this. If the document does not clearly indicate it is a draft, and the document becomes available, it will mislead readers about its status. Did this come from ISO secretariat?

@ronaldtse
Copy link
Contributor Author

This is from me — I was trying to reproduce a published ISO standard. If the document is not a draft, there is no need to indicate it’s stage. Right?

@opoudjis
Copy link
Contributor

I don't think it is safe to trust users to put in the :draft: attribute

@ronaldtse
Copy link
Contributor Author

Then we turn it around for a final attribute?

@ronaldtse
Copy link
Contributor Author

Or :official:

@opoudjis
Copy link
Contributor

opoudjis commented Nov 20, 2018

This is not the way to handle it. The information about the official status of the document is already indicated in whether the stage attribute is either 60 or absent. If it is, then the stage information should be suppressed: a document simply should never have a front page saying "IS stage". Otherwise, whenever a stage has a different value, that information must always appear on the front page, and must not be overridden.

So the actual solution to this is to have the document stage information on the front page of ISO suppressed when the stage is 60.

The draft warning is already hidden, based not on the value of :draft:, but on the stage value being less than 60. So the stage value should be used in this instance too.

Please confirm this is what you intended.

@ronaldtse
Copy link
Contributor Author

Confirmed, and this solution has to be portable.

For example, in CSD any stage before “published” should have the draft warning.

In ISO, stage 60.00 and 60.60 documents should not have the draft warning.

@ronaldtse
Copy link
Contributor Author

Confirmed, and this solution has to be portable.

For example, in CSD any stage before “published” should have the draft warning.

In ISO, stage 60.00 and 60.60 documents should not have the draft warning.

@ronaldtse ronaldtse reopened this Nov 21, 2018
@opoudjis
Copy link
Contributor

To make it portable, I am introducing a new metadata attribute: unpublished; its definition will vary for each gem.

opoudjis added a commit that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/isodoc that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-generic that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-csa that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-cc that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-gb that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-ribose that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-sample that referenced this issue Nov 26, 2018
opoudjis added a commit to metanorma/metanorma-un that referenced this issue Nov 26, 2018
@opoudjis
Copy link
Contributor

Done for all gems. Will work with next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants