-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images included in pdf are not middle aligned #85
Comments
It is true that all images in HTML and therefore PDF are left aligned, unlike in Word where they are centre aligned. @ronaldtse should I make centre alignment universal, or just for PDFs? And all flavours, or just this one? This is a CSS change, but it might impact every flavor. |
@opoudjis previously all HTML images are centered. I think it's safe to center all images across flavors. |
It may be the case where HTML "appear centered" but is actually left-aligned. In this case, let's center all images anyway. |
Agree. The center-aligned captions of those images may show the original intent to center align also the images. |
Will apply to all flavours and then release, likely today. This hadn't been obvious before because most images we deal with are 100% sized and much bigger than the HTML window. |
Interesting. The 100% sizing is only being applied to HTML anyway, and not PDF. It would be preferable for 100% to be applied only when the image is bigger than the current screen, not smaller. Investigating further: enlarging images just looks horrible. Investigating further. |
Ok, so until now, solution was: PDF: no special formatting to images. (So they ended up left aligned.) The formatting of images within figures, whether in PDF or in HTML, shall henceforth be centered, and reduced down to 100% but never enlarged past 100%: margin-left: auto; |
Happening in https://github.com/CalConnect/csd-digital-addresses. Yes, it's the same document that @ronaldtse had provided access.
How to trigger (in case you don't know):
make
Path of the problematic document (after compilation): "documents/cc-19160-6.pdf"
Symptoms:
In "documents/cc-19160-6.pdf", images included are not middle aligned, e.g. Figure 1. Hopefully, you found where "Figure 1" is and I don't have to specify all the instances.
Only happens to the pdf, but not other formats. You can try "documents/cc-19160-6.html". You name it for other formats.
Please feel free to ask if you need even more details. Thanks!
The text was updated successfully, but these errors were encountered: