Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create blog post for GML dictionary (and other components) rendering #811

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Create blog post for GML dictionary (and other components) rendering #811

merged 4 commits into from
Aug 26, 2024

Conversation

kwkwan
Copy link
Contributor

@kwkwan kwkwan commented Aug 21, 2024

Metanorma PR checklist

@kwkwan kwkwan linked an issue Aug 21, 2024 that may be closed by this pull request
Create blog post for GML dictionary (and other components) rendering #810
Closed
@kwkwan kwkwan requested a review from ronaldtse August 21, 2024 05:30
ronaldtse
ronaldtse reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kwkwan ! Can you add for each feature an example from the Plateau documents?

@kwkwan kwkwan requested a review from ronaldtse August 23, 2024 06:59
ronaldtse
ronaldtse reviewed Aug 25, 2024
View reviewed changes
_posts/2024-08-21-render-gml-dictionary-ea-diagram.adoc Outdated

.GML Dictionary File `Building_class.xml`
[source,xml]
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwkwan AsciiDoc uses 4 dashes ---- for code block delimiters not 3 backticks (that is MarkDown)

@ronaldtse ronaldtse force-pushed the gml-dictionary-post branch from 54f5fb1 to 89f4ae3 Compare August 25, 2024 06:16
@ronaldtse ronaldtse merged commit 7cd88b8 into main Aug 26, 2024
7 of 8 checks passed
@ronaldtse ronaldtse deleted the gml-dictionary-post branch August 26, 2024 10:04
This was referenced Aug 26, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create blog post for GML dictionary (and other components) rendering
2 participants
@kwkwan @ronaldtse