Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned ffi-compiler2 version to 2.0.1 #221

Closed
wants to merge 1 commit into from
Closed

Conversation

maxirmx
Copy link
Contributor

@maxirmx maxirmx commented Feb 11, 2024

Metanorma PR checklist

Workaround for https://github.com/metanorma/ruby-libmspack/issues

@maxirmx maxirmx marked this pull request as ready for review February 11, 2024 10:27
@maxirmx maxirmx requested review from CAMOBAP and ronaldtse February 11, 2024 10:27
@maxirmx
Copy link
Contributor Author

maxirmx commented Feb 11, 2024

Some tests are failing because of #222

@maxirmx
Copy link
Contributor Author

maxirmx commented Feb 11, 2024

I will go patch excavate as libmspack is used by it.
Otherwise all 'intermediate' build we keep failing (fontist, etc ...)

@ronaldtse
Copy link
Contributor

Is there any code to upstream here?

@maxirmx
Copy link
Contributor Author

maxirmx commented Feb 11, 2024

Is there any code to upstream here?

There is a change in ffi_compiler2 and this change is not portable.
My best thought is to use mini_portile instead of ffi_compiler2 but I believe it needs to be pre-approved.

@ronaldtse
Copy link
Contributor

Sorry @maxirmx I don’t understand what “pre-approved” means here.

@maxirmx
Copy link
Contributor Author

maxirmx commented Feb 11, 2024

Sorry @maxirmx I don’t understand what “pre-approved” means here.

I mean that ruby-libmspack maintainer should be ready to accept PR that changes build system and it would good to discuss it in advance

@maxirmx
Copy link
Contributor Author

maxirmx commented Feb 11, 2024

This PR shall cover all gems that use excavate
fontist/excavate#26

@maxirmx
Copy link
Contributor Author

maxirmx commented Feb 11, 2024

Closing this PR since excavate path closes the issue
It is a temporary solution anyway. Long term we need a fix in ruby-libmspack.

@maxirmx maxirmx closed this Feb 11, 2024
@maxirmx maxirmx deleted the maxirmx-fix-windows branch December 24, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants