Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(acc_op): further acceleration with CUDA unroll #112

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

JieRen98
Copy link
Collaborator

No description provided.

Benjamin-eecs
Benjamin-eecs previously approved these changes Nov 11, 2022
@XuehaiPan XuehaiPan changed the title feat(acc_op): further accelerating perf(acc_op): further acceleration with CUDA unroll Nov 11, 2022
@XuehaiPan XuehaiPan added cxx / cuda Something related to the CXX / CUDA extension enhancement New feature or request labels Nov 11, 2022
Copy link
Member

@XuehaiPan XuehaiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA tests failed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Base: 64.67% // Head: 64.64% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (96f8cfb) compared to base (3e7c857).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   64.67%   64.64%   -0.03%     
==========================================
  Files          66       66              
  Lines        2828     2826       -2     
==========================================
- Hits         1829     1827       -2     
  Misses        999      999              
Flag Coverage Δ
unittests 64.64% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/clip.py 81.25% <66.66%> (-1.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

XuehaiPan
XuehaiPan previously approved these changes Nov 11, 2022
Benjamin-eecs
Benjamin-eecs previously approved these changes Nov 11, 2022
@XuehaiPan XuehaiPan merged commit b155b15 into metaopt:main Dec 6, 2022
@XuehaiPan XuehaiPan deleted the acc_op branch December 6, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx / cuda Something related to the CXX / CUDA extension enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants