Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CMakeLists.txt): fix CUDA build for accelerated OP #53

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fix CUDA build by manually adding a new macro __CUDA_ENABLED__. Macro __CUDACC__ is not always defined by nvcc. See:

https://github.com/pytorch/pytorch/blob/4d3f7df33fa49a80b20ae328d5a5d71c655e3634/cmake/Modules_CUDA_fix/upstream/FindCUDA/run_nvcc.cmake#L190-L194

image

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • New environment (non-breaking change which adds 3rd-party environment)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added the bug Something isn't working label Aug 8, 2022
@XuehaiPan XuehaiPan self-assigned this Aug 8, 2022
@XuehaiPan XuehaiPan requested a review from JieRen98 August 8, 2022 07:14
@XuehaiPan XuehaiPan changed the title fix(CMakeLists.txt): fix CUDA build fix(CMakeLists.txt): fix CUDA build for accelerated OP Aug 8, 2022
@XuehaiPan
Copy link
Member Author

With this PR:

image

@JieRen98
Copy link
Collaborator

JieRen98 commented Aug 8, 2022

Have checked the implementations like reinterpret cast, New bee!

@XuehaiPan XuehaiPan merged commit 0f70f5e into metaopt:main Aug 8, 2022
@XuehaiPan XuehaiPan deleted the fix-cuda branch August 8, 2022 09:35
@XuehaiPan XuehaiPan added the cxx / cuda Something related to the CXX / CUDA extension label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cxx / cuda Something related to the CXX / CUDA extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants