Authorized agent [MTG-679] #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub struct ChangeAuthorizedAgent<'info> { | ||
| pub registrar: AccountLoader<'info, Registrar>, | ||
|
|
||
| // checking the PDA address is just an extra precaution, |
There was a problem hiding this comment.
redundant comment since the body of the method doesn't do any checks
kstepanovdev
requested changes
Sep 27, 2024
|
Closing in favor of #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've missed a separate authority that allows access to stake-provided features without risking the exposure of the voter authority. This PR does exactly that.
The role is named Authorized agent - its pubkey is acting as authorized rep of staking contract and may be safely stored on services that may require it - like a backend to authorize batch mints, or Aura node in a P2P authentication.
Help required
adding tests - this should be straightforward