Add Create Bid to Auction House #172

zaxozhu · 2022-07-18T06:21:27Z

Includes loading of LazyBid & Bid.

lorisleiva

Thank for that! You followed the structure very well. The base is here but I'm afraid we're not quite there yet. Have a look at the comments below.

src/plugins/auctionHouseModule/AuctionHouseClient.ts

src/plugins/auctionHouseModule/AuctionsBuildersClient.ts

src/plugins/auctionHouseModule/Bid.ts

src/plugins/auctionHouseModule/findBidByAddress.ts

src/plugins/auctionHouseModule/loadBid.ts

src/plugins/auctionHouseModule/plugin.ts

test/plugins/auctionHouseModule/createBid.test.ts

* Includes loading of LazyBid & Bid.

src/plugins/nftModule/NftClient.ts

lorisleiva

That's much better thank you. I've left some more comments. When are you planning on supporting Auctioneer instructions? It should be quite simple as you just need to swap the instruction factory based on the input.

src/plugins/auctionHouseModule/Bid.ts

src/plugins/auctionHouseModule/createBid.ts

src/plugins/nftModule/NftClient.ts

test/plugins/auctionHouseModule/createBid.test.ts

lorisleiva

Nice! I've just left two little comments and then LGTM. 🍺

test/plugins/auctionHouseModule/createBid.test.ts

lorisleiva · 2022-07-20T11:55:29Z

@zaxozhu Thanks for the changes. Not sure why the tests aren't passing. You can run a local Solana validator with the right programs loaded by running yarn amman:start on a different terminal window.

Then you can run

yarn test to run all the tests.
or esr test/**/createBid* to only run the bid tests.
or esr test/**/createBid* | tap-spec with a slightly better console output but you'll need to download tap-spec first.

zaxozhu · 2022-07-20T13:56:40Z

@lorisleiva thanks! That time I was on a different machine, where I don't have the solana test validator, so just pushed the changes to check tests here :)

src/plugins/auctionHouseModule/createBid.ts

lorisleiva

Almost there! 🙂

src/plugins/auctionHouseModule/createBid.ts

src/plugins/auctionHouseModule/Bid.ts

lorisleiva

LGTM! 🚀
Thank you!

zaxozhu requested a review from lorisleiva July 18, 2022 06:21

lorisleiva suggested changes Jul 18, 2022

View reviewed changes

zaxozhu and others added 7 commits July 19, 2022 13:46

Add Create Bid to Auction House

6b8e6c4

* Includes loading of LazyBid & Bid.

Fix styling

8249c87

refactor: alphabetical order, renaming, interface change

3482000

Fix styling

bae60e1

fix: small changes

ab97ebb

fix: load mint then

312e2d7

fix: loadBid

76d9baf

zaxozhu force-pushed the michael/create-bid branch from ef07b36 to 76d9baf Compare July 19, 2022 10:58

zaxozhu and others added 6 commits July 19, 2022 10:59

Fix styling

7b17ec6

feat: add public bid

aa42800

Fix styling

6ec1577

refactor: clean-up methods

097f794

Fix styling

db9564b

refactor: small clean-up

bb49477

zaxozhu commented Jul 19, 2022

View reviewed changes

src/plugins/nftModule/NftClient.ts Show resolved Hide resolved

zaxozhu and others added 2 commits July 19, 2022 16:14

refactor: return in loadBidOperationHandler

85f218a

Fix styling

30b9df9

lorisleiva suggested changes Jul 19, 2022

View reviewed changes

zaxozhu and others added 2 commits July 20, 2022 13:42

fix: PR comments

9b85900

Fix styling

5016786

lorisleiva suggested changes Jul 20, 2022

View reviewed changes

test/plugins/auctionHouseModule/createBid.test.ts Outdated Show resolved Hide resolved

test/plugins/auctionHouseModule/createBid.test.ts Outdated Show resolved Hide resolved

zaxozhu and others added 3 commits July 20, 2022 14:39

refactor: clean-up tests by assertThrows

40b1113

Fix styling

4534a85

fix: build

c9f3fa9

zaxozhu and others added 2 commits July 20, 2022 16:53

fix: create ATA if it doesn't exist

15b4d92

Fix styling

ab81e3f

zaxozhu commented Jul 20, 2022

View reviewed changes

src/plugins/auctionHouseModule/createBid.ts Show resolved Hide resolved

lorisleiva suggested changes Jul 20, 2022

View reviewed changes

src/plugins/auctionHouseModule/createBid.ts Outdated Show resolved Hide resolved

src/plugins/auctionHouseModule/Bid.ts Outdated Show resolved Hide resolved

zaxozhu and others added 3 commits July 20, 2022 18:21

fix: don't allow TokenWithMint

fceed06

Fix styling

85ce44f

fix: add assertion

3e01f32

lorisleiva approved these changes Jul 20, 2022

View reviewed changes

lorisleiva merged commit 25fb853 into main Jul 20, 2022

lorisleiva deleted the michael/create-bid branch July 21, 2022 08:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Create Bid to Auction House #172

Add Create Bid to Auction House #172

zaxozhu commented Jul 18, 2022

lorisleiva left a comment

lorisleiva left a comment

lorisleiva left a comment

lorisleiva commented Jul 20, 2022

zaxozhu commented Jul 20, 2022

lorisleiva left a comment

lorisleiva left a comment

Add Create Bid to Auction House #172

Add Create Bid to Auction House #172

Conversation

zaxozhu commented Jul 18, 2022

lorisleiva left a comment

Choose a reason for hiding this comment

lorisleiva left a comment

Choose a reason for hiding this comment

lorisleiva left a comment

Choose a reason for hiding this comment

lorisleiva commented Jul 20, 2022

zaxozhu commented Jul 20, 2022

lorisleiva left a comment

Choose a reason for hiding this comment

lorisleiva left a comment

Choose a reason for hiding this comment