Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing removed ix warnings and error messages #1027

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blockiosaurus
Copy link
Contributor

No description provided.

@blockiosaurus blockiosaurus requested a review from a team as a code owner February 17, 2023 17:38
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/4206167862.

@samuelvanderwaal
Copy link
Contributor

Some of the JS tests rely on specific log or error messages so you need to update those to fix CI. It looks like only two are failing right now so should be an easy fix.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/4235850619.

@samuelvanderwaal
Copy link
Contributor

Some of the JS tests rely on specific log or error messages so you need to update those to fix CI. It looks like only two are failing right now so should be an easy fix.

Actually, this is a bigger issue than I thought because it completely erases the JS error messages. I think it would probably require a Solita change to use the name as the message instead of the predefined string. It might be worth chatting with @lorisleiva about the best way to go about this since he's switching Token Metadata to use Kinobi soon.

@samuelvanderwaal samuelvanderwaal removed the request for review from a team May 12, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants