Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bubblegum: Refactor MetadataArgs to be wrapper around Metadata #1037

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Bubblegum: Refactor MetadataArgs to be wrapper around Metadata #1037

wants to merge 3 commits into from

Conversation

ngundotra
Copy link
Collaborator

@ngundotra ngundotra commented Feb 24, 2023 •
edited
Loading

This refactor is meant to deduplicate code by using the validation methods in Metadata.

Roughly accomplished as follows:

  • MetadataArgs + token ownership info ==> MetaplexMetadata
  • MetaplexMetadata performs validation checks for collection information, etc
  • MetaplexMetadata performs LeafSchema V0 validation checks on to_leaf_schema_v0

@ngundotra ngundotra changed the title Rework the metadata args into a wrapper around actual Metadata Bubblegum: Refactor MetadataArgs to be wrapper around Metadata Feb 24, 2023
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for bubblegum. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/4266168783.

@ngundotra
Copy link
Collaborator Author

If this looks good, I'll refactor the process_collection_verification_mpl_only and process_creator_verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ngundotra