Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding expiration for delegates #1063

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Apr 6, 2023

Notes

  • WIP
  • Creation time set when PDA is created.
  • Expiration checked during get_authority_type.
  • This is a draft idea that passes existing tests, but expiration functionality has not been thoroughly tested.

* Add support in Delegate and Revoke for Authority, Data,
CollectionItem, and ProgrammableConfigItem Metadata
delegates.
* Remove Update Metadata delegate.
* Modify authority check to separate out item and
collection-level delegates.
* Add V2 Update args struct to allow user to specify token
standard.
* Check that new delegates are only changing metadata
for which they are meant to have access.
* Modify Update handler to update metadata fields based
on the delegate type.
* Also add macro to help destructure UpdateArgs fields.
* Update is still changed to Data but order is preserved.
* Also remove unnecessary Option for token_record in Update.
* Add some comments clarifying authority types in Unverify.
* Return the value derived in the delegate method.
* Also add a test for Authority delegate.
* Creation time set when PDA is created.
* Expiration checked during get_authority_type.
* This is a draft idea that passes existing tests,
but expiration functionality has not been thoroughly
tested.
Base automatically changed from danenbm/new-update to master May 1, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant