Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(token-metadata): add burn_print_edition handler #684

Merged
merged 27 commits into from
Sep 19, 2022
Merged

feat(token-metadata): add burn_print_edition handler #684

merged 27 commits into from
Sep 19, 2022

Conversation

samuelvanderwaal
Copy link
Contributor

@samuelvanderwaal samuelvanderwaal commented Aug 19, 2022 •
edited
Loading

This PR adds a burn_print_edition handler to allow full burn of print editions.

Github Discussion

PRD with spec

This will be a minor version update once reviews are complete: v1.4.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2892750982.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2892750638.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2913635949.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2913869558.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2915054378.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2915081872.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2915815641.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2921479723.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/2967813189.

austbot
austbot suggested changes Sep 6, 2022
View reviewed changes
token-metadata/program/src/processor.rs Show resolved Hide resolved
token-metadata/program/src/processor.rs Outdated Show resolved Hide resolved
@austbot
Copy link
Contributor

austbot commented Sep 6, 2022

I think just one coment other wise I think this is good an lines up with expectations on supply and rarity

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3018660891.

@stegaBOB stegaBOB closed this Sep 12, 2022
@stegaBOB stegaBOB deleted the feat/burn-print-editions branch September 12, 2022 02:22
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3034605459.

@samuelvanderwaal samuelvanderwaal marked this pull request as ready for review September 14, 2022 20:51
@samuelvanderwaal samuelvanderwaal requested a review from a team as a code owner September 14, 2022 20:51
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3055977898.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3056097176.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3056266587.

austbot
austbot suggested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@austbot austbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Sam looks good,

I think the check that the edition is an edition of the passed in master edition is missing.

Also lots of debug MSG left in that can be removed.

token-metadata/program/src/instruction.rs Outdated Show resolved Hide resolved
token-metadata/program/src/processor.rs Outdated Show resolved Hide resolved
token-metadata/program/src/processor.rs Show resolved Hide resolved
token-metadata/program/src/processor.rs Outdated Show resolved Hide resolved
token-metadata/program/src/processor.rs Outdated Show resolved Hide resolved
token-metadata/program/src/processor.rs Outdated Show resolved Hide resolved
danenbm
danenbm reviewed Sep 17, 2022
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some very minor nit comments and some discussion items that could potentially lead to more tests, but overall it looks great and already well tested.

token-metadata/program/src/error.rs Outdated Show resolved Hide resolved
token-metadata/program/src/processor.rs Outdated Show resolved Hide resolved
token-metadata/program/src/processor.rs Show resolved Hide resolved
token-metadata/program/src/processor.rs Outdated Show resolved Hide resolved
token-metadata/program/src/processor.rs Show resolved Hide resolved
token-metadata/program/src/processor.rs Show resolved Hide resolved
token-metadata/program/src/processor.rs Show resolved Hide resolved
token-metadata/program/tests/burn_edition_nft.rs Show resolved Hide resolved
token-metadata/program/src/processor.rs Show resolved Hide resolved
token-metadata/program/src/processor.rs Show resolved Hide resolved
austbot
austbot previously approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@austbot austbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my end but @danenbm has some good ideas in here

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3085044246.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3085354539.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/3085578383.

samuelvanderwaal
samuelvanderwaal commented Sep 19, 2022
View reviewed changes
Copy link
Contributor Author

@samuelvanderwaal samuelvanderwaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version minor

danenbm
danenbm approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelvanderwaal samuelvanderwaal merged commit 0d99b68 into master Sep 19, 2022
@samuelvanderwaal samuelvanderwaal deleted the feat/burn-print-editions branch September 19, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm approved these changes

@austbot austbot austbot left review comments

Assignees

@austbot austbot

@danenbm danenbm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelvanderwaal @austbot @danenbm @stegaBOB